[capital] Code generation: update services and models#465
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces automated changes for the capital service, primarily by adding a new DynamicOffersApi. The changes are generally sound, but I've identified a couple of areas for improvement in the newly generated code. My feedback focuses on enhancing maintainability by reducing code duplication and adhering to Python best practices by avoiding shadowing built-in functions. Addressing these points in the code generator will improve the quality of future automated changes.
| self.service = "capital" | ||
| self.baseUrl = "https://balanceplatform-api-test.adyen.com/capital/v1" |
There was a problem hiding this comment.
The service and baseUrl attributes are hardcoded and duplicated across all API classes in the capital service (DynamicOffersApi, GrantAccountsApi, GrantOffersApi, GrantsApi). This violates the DRY (Don't Repeat Yourself) principle and makes maintenance harder. To improve maintainability, consider defining these in a shared base class for all capital services or as constants in a shared module.
There was a problem hiding this comment.
Good feedback, but not in scope of this PR as it's generated code. We can create a follow-up ticket internally
| self, request, id, idempotency_key=None, **kwargs | ||
| ): | ||
| """ | ||
| Calculate a preliminary offer for a selected financing amount | ||
| """ | ||
| endpoint = self.baseUrl + f"/dynamicOffers/{id}/calculate" |
There was a problem hiding this comment.
The parameter name id shadows the built-in Python function id(). According to the PEP 8 style guide, it is recommended to use a trailing underscore like id_ to avoid such conflicts.
| self, request, id, idempotency_key=None, **kwargs | |
| ): | |
| """ | |
| Calculate a preliminary offer for a selected financing amount | |
| """ | |
| endpoint = self.baseUrl + f"/dynamicOffers/{id}/calculate" | |
| self, request, id_, idempotency_key=None, **kwargs | |
| ): | |
| """ | |
| Calculate a preliminary offer for a selected financing amount | |
| """ | |
| endpoint = self.baseUrl + f"/dynamicOffers/{id_}/calculate" |
There was a problem hiding this comment.
Good feedback, but not in socpe as this is generated code
| def create_static_offer_from_dynamic_offer(self, request, id, idempotency_key=None, **kwargs): | ||
| """ | ||
| Create a static offer for a selected financing amount | ||
| """ | ||
| endpoint = self.baseUrl + f"/dynamicOffers/{id}/grantOffer" |
There was a problem hiding this comment.
The parameter name id shadows the built-in Python function id(). According to the PEP 8 style guide, it is recommended to use a trailing underscore like id_ to avoid such conflicts.
| def create_static_offer_from_dynamic_offer(self, request, id, idempotency_key=None, **kwargs): | |
| """ | |
| Create a static offer for a selected financing amount | |
| """ | |
| endpoint = self.baseUrl + f"/dynamicOffers/{id}/grantOffer" | |
| def create_static_offer_from_dynamic_offer(self, request, id_, idempotency_key=None, **kwargs): | |
| """ | |
| Create a static offer for a selected financing amount | |
| """ | |
| endpoint = self.baseUrl + f"/dynamicOffers/{id_}/grantOffer" |
There was a problem hiding this comment.
Good feedback, but not in scope as generated code
2 participants
This PR contains the automated changes for the
capitalservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.